[PATCH] D21552: [ELF] - Teach llvm-readobj to print dependencies of SHT_GNU_verdef and refactor dumping method.
Rafael Ávila de Espíndola via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 21 12:23:11 PDT 2016
rafael added inline comments.
================
Comment at: tools/llvm-readobj/ELFDumper.cpp:570
@@ +569,3 @@
+
+ DictScope Dep(W, "Dependencies");
+ const uint8_t *PAux = P + VD->vd_aux + VD->getAux()->vda_next;
----------------
The "spec" used the name "predecessor versions". Maybe this should be "Predecessors". I assume that if you have
foo {
} bar;
bar {
} zed;
it will chain them?
If that is the case, maybe it would be better to print just the first predecessor?
In any case, I agree with Davide, we need a test :-)
http://reviews.llvm.org/D21552
More information about the llvm-commits
mailing list