[PATCH] D21409: Emit a swap for STXVD2X when it's emitted by matching a 'store' node

Ehsan Amiri via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 21 11:41:57 PDT 2016


amehsan added a comment.

> Yes, I think it would be a good idea to get rid of the custom ISD nodes for LXVD2X and STXVD2X as well as the XXSWAPD node. This way we will always get a swap after the load and before the store as we did with the custom code. Furthermore, we can lower int_ppc_vsx_stxvd2x directly to the STXVD2X instruction (and conversely for the load). This will ensure that if someone uses the intrinsic through a builtin, they just get the instruction without the swap allowing us to trivially implement vec_xl_be/vec_xst_be for 64-bit data types.

> 

> I think this is a worth-while simplification and can update the patch to do that if @hfinkel and @wschmidt agree.


As we discussed separately, let's first wait for the other patch to be approved. Then re-purposing this patch to do some clean up in the code, will depend on priorities.


Repository:
  rL LLVM

http://reviews.llvm.org/D21409





More information about the llvm-commits mailing list