[PATCH] D21562: [AMDGPU] Wave and register controls

[Konstantin Zhuravlyov via llvm-commits]

kzhuravl added inline comments.

================
Comment at: lib/Target/AMDGPU/AMDGPUSubtarget.h:445
@@ +444,3 @@
+  /// subtarget's specifications.
+  std::pair<unsigned, unsigned> getFlatWorkGroupSizes(const Function &F) const;
+
----------------
The reason I put this function here is because it either returns flat work group size for a given function or subtarget's defaults, but I am not sure if this is the right place.

================
Comment at: lib/Target/AMDGPU/AMDGPUSubtarget.h:455
@@ -366,1 +454,3 @@
+  /// by flat work group size, register usage, and/or lds usage.
+  std::pair<unsigned, unsigned> getNumActiveWavesPerEU(const Function &F) const;
 };
----------------
The reason I put this function here is because it either returns number of active waves per execution unit for a given function or subtarget's defaults, but I am not sure if this is the right place.

================
Comment at: lib/Target/AMDGPU/SIRegisterInfo.h:226
@@ +225,3 @@
+  /// does not meet number of active waver per execution unit requirement.
+  unsigned getMaxNumSGPRs(const MachineFunction &MF) const;
+
----------------
Is there a better place for this function?

================
Comment at: lib/Target/AMDGPU/SIRegisterInfo.h:261
@@ +260,3 @@
+  /// does not meet number of active waves per execution unit requirement.
+  unsigned getMaxNumVGPRs(const MachineFunction &MF) const;
+
----------------
Is there a better place for this function?


http://reviews.llvm.org/D21562