[PATCH] D21555: [ELF] - Do not allow mix global symbols version.

[Davide Italiano via llvm-commits]

davide added a subscriber: davide.
davide added a comment.

I was a little bit confused when I originally tried versioning and noticed you can (both in gold and bfd) duplicate symbols in the map. The fact they just emit a warning (and not an error) makes me think there's some software in the wild which abuses of this feature.

That said, I entirely advocate being a little bit more strict, but, I'd rather finish the version script support (or at least make it good enough that it can understand FreeBSD base system, large C++ applications etc..) before introducing these restrictions.
If you want a large test case, you can try linking gentoo packages/FreeBSD packages. I tried the latter and realized many failures happened in version script support (e.g. comments not parsed correctly).

tl;dr: I'd rather put this on hold until we got the basics right, or at least until we realized being more strict doesn't cause additional headache down the road. YMMV.


http://reviews.llvm.org/D21555