[PATCH] D21428: Fix feature RAS assigned to ARMv8.1 when it should be ARMv8.2

Roger Ferrer Ibanez via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 21 07:18:24 PDT 2016


rogfer01 added a comment.

Indeed this does not have any effect. I could even remove the enumerator from the macro and nothing changes.

AArch64 has a similar `AArch64::AEK_RAS` in `armv8.2-a` and it is handled in `AArch64::getExtensionFeatures` (in `lib/Support/TargetParser.cpp`) but (unless I'm missing something very obvious) it is not called from anywhere.

Conversely, `ARM::getExtensionFeatures` is called from `tools/clang/lib/Basic/Targets.cpp` but does not handle `ARM::AEK_RAS`. Handling it like AArch64 does not have any effect either.


http://reviews.llvm.org/D21428





More information about the llvm-commits mailing list