[PATCH] D21550: [lld] support --trace-symbol (alias -y) option

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 21 06:23:35 PDT 2016


grimar added inline comments.

================
Comment at: ELF/InputFiles.cpp:316
@@ -315,1 +315,3 @@
 
+// print the module names which references and defines the 
+// notified symbols provided through -y or trace-symbol option
----------------
Comments should be started from uppercase and ended with dot.

================
Comment at: test/ELF/Inputs/trace-symbols-foo-global.s:22
@@ +21,2 @@
+	.ident	"GCC: (Ubuntu 4.8.4-2ubuntu1~14.04.1) 4.8.4"
+	.section	.note.GNU-stack,"", at progbits
----------------
I think this file contains too much excessive data for test. Like file name, .ident and asm code.
Can you cleanup this ?


http://reviews.llvm.org/D21550





More information about the llvm-commits mailing list