[PATCH] D21509: [asan] fix false dynamic-stack-buffer-overflow report with constantly-sized dynamic allocas

[Maxim Ostapenko via llvm-commits]

m.ostapenko added a comment.

I think you don't need two test files, could you combine them to one source file (you'll probably want use ifdefs)?


================
Comment at: lib/Transforms/Instrumentation/AddressSanitizer.cpp:468
@@ -461,2 +467,3 @@
   // Check if we have dynamic alloca.
   bool isDynamicAlloca(AllocaInst &AI) const {
+    return !AI.isStaticAlloca();
----------------
zaks.anna wrote:
> zaks.anna wrote:
> > You probably can get rid of the helper function now.
> I was trying to figure out why we have the check for AI.isArrayAllocation() here and I cannot.. Looks like it was added here:
> 
>  http://reviews.llvm.org/D6055
> I was trying to figure out why we have the check for AI.isArrayAllocation() here and I cannot.. Looks like it was added here:

> http://reviews.llvm.org/D6055

Yeah, this is a artifact from initial implementation. I don't remember exact reason why I placed this check here, but this probably was a mistake.


http://reviews.llvm.org/D21509