[PATCH] D21530: Moving loop vectorization pass before loop-unroller.

Hal Finkel via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 20 23:25:13 PDT 2016


hfinkel requested changes to this revision.
hfinkel added a comment.
This revision now requires changes to proceed.

This is not the right solution to this problem. Loop vectorization is not a canonicalization pass, but a lowering pass, and should not be moved into the canonicalization part of the pipeline.

Should these loops be fully unrolled at all? The targets can influence the thresholds used for unrolling, and perhaps those need better tuning. After a loop is fully unrolled, if we're missing vectorization opportunities, why is the SLP vectorizer not catching them?


http://reviews.llvm.org/D21530





More information about the llvm-commits mailing list