[PATCH] D21488: [polly] Fix some Clang-tidy and Include What You Use warnings; other minor fixes

[Tobias Grosser via llvm-commits]

grosser added a subscriber: grosser.
grosser added a comment.

Hi Eugene,

thank you for all these fixes. They look indeed great.

Most of them seem to be clear improvements, so I would be very happy to
see them committed. Applying a large change of uncommented refactoring -
the state the patch seems to be in ATM - will fix the current issues,
but unfortunately will fail to teach me and other developers about good
coding style and which tools we can use to ensure we follow in the
future a coding style that matches the changes you propose.

To teach this, we would -- in the optimal case -- split this larger
patch into individual thematic patches and add for each patch a
description of what has changed, why the new form is preferable over the
old form, and how the change was created (automatically by a specific
tool or manually).

You do not happen to have a git patch sequence which documents the
individual thematic changes you performed? In case you have not, would
it be possible to create such a sequence and use the commit messages to
add context information that helps to educate people about the changes
you propose? I believe this would be of great help to ensure your
changes will improve the code style of Polly also in the longer term.

Best,
Tobias


Repository:
  rL LLVM

http://reviews.llvm.org/D21488