[llvm] r273148 - [AARCH64] Add support for Broadcom Vulcan

Renato Golin via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 20 14:42:08 PDT 2016


On 20 June 2016 at 21:50, Eric Christopher via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> So, why are all of the processors given as SubtargetFeatures as well as
> processors? This seems ... less than optimal. I.e. I can't come up with a
> reason I'd want to say "llc -mattr=+vulcan" rather than llc -mcpu=vulcan.

Those features are not only for llc -mattr, but they define what
features a target will have and it's a convenient way to group things
together without specifying Target.isCortexA53().

Maybe it could be done in a different way, but this has been the way
for a long time now, and AArch64 only copied from ARM. :)

I don't think anyone does (or should) use it in -mattr anyway. Maybe
mattr is another candidate for using the target parser...

cheers,
--renato


More information about the llvm-commits mailing list