[PATCH] D21509: [asan] fix false dynamic-stack-buffer-overflow report with constantly-sized dynamic allocas

[Anna Zaks via llvm-commits]

zaks.anna added a comment.

Since this is an IR-pass change, could you add a regression test checking the changes made by the -asan pass.


================
Comment at: lib/Transforms/Instrumentation/AddressSanitizer.cpp:468
@@ -461,2 +467,3 @@
   // Check if we have dynamic alloca.
   bool isDynamicAlloca(AllocaInst &AI) const {
+    return !AI.isStaticAlloca();
----------------
You probably can get rid of the helper function now.

================
Comment at: lib/Transforms/Instrumentation/AddressSanitizer.cpp:906
@@ -899,2 +905,3 @@
   bool IsInteresting =
+      isDynamicAlloca(AI) ||
       (AI.getAllocatedType()->isSized() &&
----------------
Why is this needed?


http://reviews.llvm.org/D21509