[PATCH] D21507: Changes after running check modernize-use-emplace (D20964)
Piotr Padlewski via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 20 13:54:51 PDT 2016
Prazek added a comment.
In http://reviews.llvm.org/D21507#462210, @jlebar wrote:
> There seem to be many nontrivial whitespace errors introduced by this patch. For example,
>
> - Attrs.push_back(HTMLStartTagComment::Attribute(Ident.getLocation(),
> - Ident.getHTMLIdent()));
> + Attrs.emplace_back(Ident.getLocation(),
> + Ident.getHTMLIdent());
>
>
> and
>
> - BitGroups.push_back(BitGroup(LastValue, LastRLAmt, LastGroupStartIdx,
> - i-1));
> + BitGroups.emplace_back(LastValue, LastRLAmt, LastGroupStartIdx,
> + i-1);
>
That's right. I will git-clang-format it before pushing upstream. This is just raw diff of what check does.
Repository:
rL LLVM
http://reviews.llvm.org/D21507
More information about the llvm-commits
mailing list