[PATCH] D21524: [asan] Fix shifting compiler warnings when compiler in 64-bits

Etienne Bergeron via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 20 12:30:53 PDT 2016


etienneb added a comment.

In http://reviews.llvm.org/D21524#462485, @rnk wrote:

> LLP64 strikes again. =P
>
> I wonder if sanitizer_common.h should have this in it instead and use it everywhere instead of ((uptr)1): `enum : uptr { UPtrOne = 1 };`. Seems like a style question for Kostya.


Or, we could have a specific macro for address space shifting.

  #define SHIFT(offset) (((uptr)1) << (offset))

With a better name :)


http://reviews.llvm.org/D21524





More information about the llvm-commits mailing list