[llvm] r273189 - [MemorySSA] Clean up unit tests a tiny bit. NFC.

George Burgess IV via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 20 12:13:07 PDT 2016


Author: gbiv
Date: Mon Jun 20 14:13:07 2016
New Revision: 273189

URL: http://llvm.org/viewvc/llvm-project?rev=273189&view=rev
Log:
[MemorySSA] Clean up unit tests a tiny bit. NFC.

We recently made MemorySSA own the walker it creates. As a part of this,
the MSSA test fixture was changed to have a `Walker*` instead of a
`unique_ptr<Walker>`. So, we no longer need to do `&*Walker` in order to
get a `Walker*`.

Modified:
    llvm/trunk/unittests/Transforms/Utils/MemorySSA.cpp

Modified: llvm/trunk/unittests/Transforms/Utils/MemorySSA.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/Transforms/Utils/MemorySSA.cpp?rev=273189&r1=273188&r2=273189&view=diff
==============================================================================
--- llvm/trunk/unittests/Transforms/Utils/MemorySSA.cpp (original)
+++ llvm/trunk/unittests/Transforms/Utils/MemorySSA.cpp Mon Jun 20 14:13:07 2016
@@ -88,7 +88,7 @@ TEST_F(MemorySSATest, RemoveMemoryAccess
 
   setupAnalyses();
   MemorySSA &MSSA = Analyses->MSSA;
-  MemorySSAWalker *Walker = &*Analyses->Walker;
+  MemorySSAWalker *Walker = Analyses->Walker;
 
   // Before, the load will be a use of a phi<store, liveonentry>. It should be
   // the same after.
@@ -148,7 +148,7 @@ TEST_F(MemorySSATest, TestTripleStore) {
 
   setupAnalyses();
   MemorySSA &MSSA = Analyses->MSSA;
-  MemorySSAWalker *Walker = &*Analyses->Walker;
+  MemorySSAWalker *Walker = Analyses->Walker;
 
   unsigned I = 0;
   for (StoreInst *V : {S1, S2, S3}) {
@@ -180,7 +180,7 @@ TEST_F(MemorySSATest, TestStoreAndLoad)
 
   setupAnalyses();
   MemorySSA &MSSA = Analyses->MSSA;
-  MemorySSAWalker *Walker = &*Analyses->Walker;
+  MemorySSAWalker *Walker = Analyses->Walker;
 
   MemoryAccess *LoadClobber = Walker->getClobberingMemoryAccess(LI);
   EXPECT_EQ(LoadClobber, MSSA.getMemoryAccess(SI));
@@ -210,7 +210,7 @@ TEST_F(MemorySSATest, TestStoreDoubleQue
 
   setupAnalyses();
   MemorySSA &MSSA = Analyses->MSSA;
-  MemorySSAWalker *Walker = &*Analyses->Walker;
+  MemorySSAWalker *Walker = Analyses->Walker;
 
   MemoryAccess *StoreAccess = MSSA.getMemoryAccess(SI);
   MemoryLocation StoreLoc = MemoryLocation::get(SI);




More information about the llvm-commits mailing list