[PATCH] D21496: LoadCombine Load Aliasing Fix

[David Majnemer via llvm-commits]

majnemer added inline comments.

================
Comment at: /Users/rriddle/Desktop/llvm/llvm/lib/Transforms/Scalar/LoadCombine.cpp:134-135
@@ -136,2 +133,4 @@
 bool LoadCombine::aggregateLoads(SmallVectorImpl<LoadPOPPair> &Loads) {
-  assert(Loads.size() >= 2 && "Insufficient loads!");
+  if(Loads.size() < 2)
+    return false;
+
----------------
Please appropriately format this.

================
Comment at: /Users/rriddle/Desktop/llvm/llvm/lib/Transforms/Scalar/LoadCombine.cpp:250
@@ +249,3 @@
+      // Try to aggregate.
+      if(aggregateLoads(Loads->second))
+        Combined = true;
----------------
Please format this appropriately.


http://reviews.llvm.org/D21496