[PATCH] D21271: Fix `InstCombine` to not widen metadata on store-to-load forwarding

[Eli Friedman via llvm-commits]

eli.friedman added a comment.

I can add a comment; it would look something like this:

  /// If \c isLoadCSE is non-null and a previous load from the same pointer is found, the value
  /// is set to true; if a previous store to the same pointer is found, it is set to false.
  /// This allows the caller to tell whether it needs to update the metadata of the returned value.

Is that sufficient?  Or do I need to include an explanation of why load CSE involves updating the metadata?


http://reviews.llvm.org/D21271