[PATCH] D21513: [CFLAA] Try to be less conservative on more functions

Jia Chen via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 20 09:53:26 PDT 2016


grievejia added inline comments.

================
Comment at: lib/Analysis/CFLAliasAnalysis.cpp:380
@@ -379,3 +379,3 @@
   static bool isFunctionExternal(Function *Fn) {
-    return Fn->isDeclaration() || !Fn->hasLocalLinkage();
+    return !Fn->hasExactDefinition();
   }
----------------
I think I'll just keep isFunctionExternal() here, in case other alias analysis-specific checks are needed.


http://reviews.llvm.org/D21513





More information about the llvm-commits mailing list