[llvm] r273160 - Revert "[LoopIdiom] Don't remove dead operands manually"

[Cong Liu via llvm-commits]

Author: congliu
Date: Mon Jun 20 10:22:15 2016
New Revision: 273160

URL: http://llvm.org/viewvc/llvm-project?rev=273160&view=rev
Log:
Revert "[LoopIdiom] Don't remove dead operands manually"

This reverts commit r273132.
Breaks multiple test under /llvm/test:Transforms (e.g.
llvm/test:Transforms/LoopIdiom/basic.ll.test) under asan.

Removed:
    llvm/trunk/test/Transforms/LoopIdiom/pr28196.ll
Modified:
    llvm/trunk/lib/Transforms/Scalar/LoopIdiomRecognize.cpp

Modified: llvm/trunk/lib/Transforms/Scalar/LoopIdiomRecognize.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/LoopIdiomRecognize.cpp?rev=273160&r1=273159&r2=273160&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/Scalar/LoopIdiomRecognize.cpp (original)
+++ llvm/trunk/lib/Transforms/Scalar/LoopIdiomRecognize.cpp Mon Jun 20 10:22:15 2016
@@ -159,7 +159,8 @@ static void deleteDeadInstruction(Instru
   SmallVector<Value *, 16> Operands(I->value_op_begin(), I->value_op_end());
   I->replaceAllUsesWith(UndefValue::get(I->getType()));
   I->eraseFromParent();
-  RecursivelyDeleteTriviallyDeadInstructions(I, TLI);
+  for (Value *Op : Operands)
+    RecursivelyDeleteTriviallyDeadInstructions(Op, TLI);
 }
 
 //===----------------------------------------------------------------------===//

Removed: llvm/trunk/test/Transforms/LoopIdiom/pr28196.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/LoopIdiom/pr28196.ll?rev=273159&view=auto
==============================================================================
--- llvm/trunk/test/Transforms/LoopIdiom/pr28196.ll (original)
+++ llvm/trunk/test/Transforms/LoopIdiom/pr28196.ll (removed)
@@ -1,26 +0,0 @@
-; RUN: opt -loop-idiom -S < %s | FileCheck %s
-
-target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
-target triple = "x86_64-unknown-linux-gnu"
-
-define void @test1() {
-entry:
-  br label %for.body.preheader
-
-for.body.preheader:                               ; preds = %for.cond
-  br label %for.body
-
-for.body:                                         ; preds = %for.body, %for.body.preheader
-  %indvars.iv = phi i32 [ 0, %for.body.preheader ], [ %indvars.iv.next, %for.body ]
-  %add.ptr3 = getelementptr inbounds i32, i32* null, i32 %indvars.iv
-  %add.ptr4 = getelementptr inbounds i32, i32* %add.ptr3, i32 1
-  %0 = load i32, i32* %add.ptr4, align 4
-  store i32 %0, i32* %add.ptr3, align 4
-  %indvars.iv.next = add nsw i32 %indvars.iv, 1
-  %exitcond = icmp ne i32 %indvars.iv.next, 6
-  br i1 %exitcond, label %for.body, label %for.body.preheader
-}
-
-; CHECK-LABEL: define void @test1(
-; CHECK: call void @llvm.memcpy.p0i8.p0i8.i64(i8* null, i8* inttoptr (i64 4 to i8*), i64 24, i32 4, i1 false)
-; CHECK-NOT: store