[PATCH] D21513: [CFLAA] Try to be less conservative on more functions
Jia Chen via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 20 07:30:27 PDT 2016
grievejia added inline comments.
================
Comment at: lib/Analysis/CFLAliasAnalysis.cpp:371
@@ -370,3 +370,3 @@
static bool isFunctionExternal(Function *Fn) {
- return Fn->isDeclaration() || !Fn->hasLocalLinkage();
+ return Fn->isDeclaration() || Fn->isInterposable();
}
----------------
sanjoy wrote:
> If this is doing inter-procedural alias analysis, then you need to use `Fn-> hasExactDefinition()`.
Thank you so much for pointing that out!
http://reviews.llvm.org/D21513
More information about the llvm-commits
mailing list