[PATCH] D20913: [asan] add primitives that allow coroutine implementations

Dmitry Vyukov via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 20 06:11:44 PDT 2016


dvyukov added a comment.

> One consequence is that the fake frame that should be allocated when entering the fiber is not, only the functions called from there have one.


That's a consequence of manual annotations. If a program uses swapcontext, and we intercept and annotate it, then it won't happen, right?
I think it is fine. The guideline for manual annotations should then recommend to introduce an additional function that merely finishes the switch and calls real non-inlinable fiber body. Worth noting in __sanitizer_start_switch_fiber comment, and, yes, it needs some comment.


http://reviews.llvm.org/D20913





More information about the llvm-commits mailing list