[PATCH] D21500: [AARCH64] Add support for Broadcom Vulcan

pankaj gode via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 20 03:17:42 PDT 2016


pgode marked 2 inline comments as done.

================
Comment at: lib/Target/AArch64/AArch64.td:244
@@ -235,2 +243,3 @@
 def : ProcessorModel<"kryo", KryoModel, [ProcKryo]>;
+def : ProcessorModel<"vulcan", NoSchedModel, [ProcVulcan]>;
 
----------------
rengolin wrote:
> Isn't it even remotely similar to an A53/A57?
This processor is similar to A57.  This patch is for introducing Vulcan in LLVM. 
We plan to submit the Vulcan scheduler model in subsequent patches, hence 'NoSchedModel.

================
Comment at: lib/Target/AArch64/AArch64Subtarget.cpp:74
@@ -73,2 +73,3 @@
     break;
+  case Vulcan: break;
   case CortexA35: break;
----------------
rengolin wrote:
> Nit: This could be a fall-through for all remaining cases...
We plan to add Vulcan specific details in subsequent patches under this case. Please let me know if that is ok.  


http://reviews.llvm.org/D21500





More information about the llvm-commits mailing list