[PATCH] D21496: LoadCombine Load Aliasing Fix
Eli Friedman via llvm-commits
llvm-commits at lists.llvm.org
Sun Jun 19 14:19:01 PDT 2016
eli.friedman added inline comments.
================
Comment at: /Users/rriddle/Desktop/llvm/llvm/lib/Transforms/Scalar/LoadCombine.cpp:238
@@ +237,3 @@
+ // Loop over each load and check to see if it is aliased by
+ // this instruction.
+ auto LoadMapEnd = LoadMap.end();
----------------
Weird indentation.
================
Comment at: /Users/rriddle/Desktop/llvm/llvm/lib/Transforms/Scalar/LoadCombine.cpp:256
@@ +255,3 @@
+ Combined = true;
+ }
+
----------------
This block of code is very similar to the body of LoadCombine::combineLoads; please refactor.
http://reviews.llvm.org/D21496
More information about the llvm-commits
mailing list