[PATCH] Make local: optional.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 17 06:25:16 PDT 2016


LGTM

On Fri, Jun 17, 2016 at 5:29 AM, Rafael EspĂ­ndola <
rafael.espindola at gmail.com> wrote:

> Updated version with Peter's suggestion.
>
> Cheers,
> Rafael
>
>
> On 16 June 2016 at 19:22, Peter Collingbourne <peter at pcc.me.uk> wrote:
> > Or we could just rename/reverse the sense of the existing VersionScript
> flag
> > -- we aren't using it for anything else.
> >
> > Peter
> >
> > On Thu, Jun 16, 2016 at 3:43 PM, Rui Ueyama via llvm-commits
> > <llvm-commits at lists.llvm.org> wrote:
> >>
> >> I think we should add a new member to Config (say, `bool
> >> VersionScriptGlobalByDefault`) to manage "existence of version script"
> and
> >> "whether symbols are hidden or global by default" separately.
> >>
> >> On Thu, Jun 16, 2016 at 2:53 PM, Rafael EspĂ­ndola
> >> <rafael.espindola at gmail.com> wrote:
> >>>
> >>> Doing that in an anonymous version is a bit silly, but this opens the
> >>> way for supporting it in general.
> >>>
> >>> Since we don't support actual versions, for now we just disable the
> >>> version script if we detect that it is missing a local.
> >>>
> >>> Cheers,
> >>> Rafael
> >>
> >>
> >>
> >> _______________________________________________
> >> llvm-commits mailing list
> >> llvm-commits at lists.llvm.org
> >> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
> >>
> >
> >
> >
> > --
> > --
> > Peter
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160617/2b6c7b2d/attachment.html>


More information about the llvm-commits mailing list