[PATCH] D21454: [PM] Port MergedLoadStoreMotion to the new pass manager, take two.

David Li via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 16 21:38:57 PDT 2016


davidxl added inline comments.

================
Comment at: include/llvm/Transforms/Scalar/MergedLoadStoreMotion.h:95
@@ +94,3 @@
+  // and the new pass manager.
+  MergedLoadStoreMotion Impl;
+};
----------------
Any reason we need to make it a member field, instead of just being created as a local instance at the time it is run? With that there is no need to hoist the class into the header.


http://reviews.llvm.org/D21454





More information about the llvm-commits mailing list