[PATCH] D20116: Add nosideeffects function attribute
Tom Stellard via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 16 14:19:39 PDT 2016
tstellarAMD added a comment.
In http://reviews.llvm.org/D20116#459637, @mehdi_amini wrote:
> In http://reviews.llvm.org/D20116#458920, @tstellarAMD wrote:
>
> > Ping.
>
>
> You're pinging but my impression is that it is waiting on you to address nhaehnle comment, did you miss it or did I miss an answer?
I didn't address it specifically, but I was planning to address it by waiting for http://reviews.llvm.org/D18714 to be committed first, since that patch has the correct test case. I was actually hoping that pinging this patch would get people to look at http://reviews.llvm.org/D18714 too, since that's been outstanding for much longer.
http://reviews.llvm.org/D20116
More information about the llvm-commits
mailing list