[PATCH] D21421: [NVPTX] Improve lowering of byval args of device functions.

Justin Lebar via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 16 14:02:57 PDT 2016


jlebar added a comment.

We need to add comments in this code explaining

- although this is an optimization, it is also needed to work around a bug in ptxas.
- exactly what that bug is.
- exactly how this works around the problem.

If it's OK with you, I'm not going to read the discussion here and just look at the comments in the code, as a way to prove to myself that the comments there actually explain the problem in a way that at least I can understand.


http://reviews.llvm.org/D21421





More information about the llvm-commits mailing list