[PATCH] D21439: [ELF] - Handle every global as unversioned export in versioned script.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 16 10:59:47 PDT 2016


grimar added a comment.

In http://reviews.llvm.org/D21439#460016, @ruiu wrote:

> Can you organize this as a part of recursive descendant parser? You can create a function parseVersion and do something like this.
>
>   if (peek() == "{") {
>     parseVersin();
>     if (!atEOF())
>       setError("anonymous version definition is used in combination with other version definitions");
>     return;
>   }
>   while (!atEOF()) {
>     StringRef Version = next();
>     parseVersion();
>   }


Looks really better IMO. Thanks for hint !


http://reviews.llvm.org/D21439





More information about the llvm-commits mailing list