[PATCH] D21400: AMDGPU: Emit R_AMDGPU_ABS32_{HI, LO} for scratch buffer relocations

[Tom Stellard via llvm-commits]

tstellarAMD added inline comments.

================
Comment at: include/llvm/Object/RelocVisitor.h:144-146
@@ +143,5 @@
+        switch (RelocType) {
+        case llvm::ELF::R_AMDGPU_ABS32_LO:
+        case llvm::ELF::R_AMDGPU_ABS32_HI:
+          return visitELF_AMDGPU_32(R, Value);
+        default:
----------------
kzhuravl wrote:
> This processes HI relocations as LO. Should not LO and HI be processed differently, or am I missing something?
The RelocVisitor seems to only be used in DwarfContext.cpp.  It's not clear me what it's even supposed to do with absolute relocations.  Is this code even necessary?


http://reviews.llvm.org/D21400