[PATCH] D21370: [mips] Emit a JALR with $rd equal to $zero, instead of a JR in MIPS32R6.

Simon Dardis via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 16 07:53:15 PDT 2016


sdardis accepted this revision.
sdardis added a comment.
This revision is now accepted and ready to land.

LGTM.

In principle, you could exploit a redundancy in the pre-MIPSR6 instruction set to simply always emit "jalr, $zero, $at" rather than switching on the ISA.

I believe it is best that we do switch on ISA for clearer disassembly though.


http://reviews.llvm.org/D21370





More information about the llvm-commits mailing list