[PATCH] D21018: [ELF] - Basic versioned symbols support implemented.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 16 06:25:31 PDT 2016


>rafael added inline comments.
>
>================
>Comment at: ELF/SymbolListFile.cpp:80
>@@ +79,3 @@
>+private:
>+  void parseUnversionedScript();
>+  void parseVersionedScript();
>----------------
>Do we really need to duplicate the parsing? We should be able to have a single parser and take different actions based on the name, no?

That was done in that way in initial version of the patch (please see diff 1). 
And Rui requested to separate this during review.

George.




More information about the llvm-commits mailing list