[PATCH] D21410: [pdb] Change type visitor pattern to use dynamic polymorphism

[Zachary Turner via llvm-commits]

I can't check the code at the moment but somewhere in Error.h it
specifically recommends using the explicit `Error::success` syntax
On Wed, Jun 15, 2016 at 3:23 PM Rui Ueyama <ruiu at google.com> wrote:

> ruiu accepted this revision.
> ruiu added a comment.
> This revision is now accepted and ready to land.
>
> LGTM
>
>
> ================
> Comment at: lib/DebugInfo/CodeView/CVTypeVisitor.cpp:1
> @@ +1,2 @@
> +//===- CVTypeVisitor.cpp ----------------------------------------*- C++
> -*-===//
> +//
> ----------------
> Remove `-*- C++ -*-` since this file has .cpp extnesion.
>
> ================
> Comment at: lib/DebugInfo/CodeView/CVTypeVisitor.cpp:21
> @@ +20,3 @@
> +  Data = Data.drop_front(sizeof(*Res));
> +  return Error::success();
> +}
> ----------------
> This is not directly related to this change, but should we write `return
> {}` instead of `return Error::success()` for the sake of brevity?
>
>
> http://reviews.llvm.org/D21410
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160615/afd6f43a/attachment.html>