[PATCH] D21405: [PGO] IRPGO pre-cleanup pass changes

[Rong Xu via llvm-commits]

xur added a comment.

comments are inlined.


================
Comment at: lib/Transforms/IPO/PassManagerBuilder.cpp:122
@@ +121,3 @@
+static cl::opt<bool>
+    RunPreInliner("preinline", cl::init(true), cl::Hidden, cl::ZeroOrMore,
+                  cl::desc("Enable pre-instrumentation inliner"));
----------------
vsk wrote:
> Is zero or more needed?
probably not needed.

================
Comment at: lib/Transforms/IPO/PassManagerBuilder.cpp:128
@@ -121,1 +127,3 @@
+                      cl::desc("Disable pre-instrumentation inliner"));
+
 PassManagerBuilder::PassManagerBuilder() {
----------------
mehdi_amini wrote:
> Why two options?
this is adopted from the earlier implementation where we have a separated inline passes. Since now we are using the standard inliner with different thresholds. I think we can get rid of preinline option and keep disable-preinline option.

================
Comment at: lib/Transforms/IPO/PassManagerBuilder.cpp:228
@@ +227,3 @@
+  return 75;
+}
+
----------------
mehdi_amini wrote:
> These seem pretty arbitrary numbers?
No. They are from current Os and Oz thresholds

================
Comment at: lib/Transforms/IPO/PassManagerBuilder.cpp:245
@@ -214,1 +244,3 @@
+    addExtensionsToPM(EP_Peephole, MPM);
+  }
   if (!PGOInstrGen.empty()) {
----------------
mehdi_amini wrote:
> Where is this list coming from? How is it computed?
I came up this list. I'm open to add most passes.


http://reviews.llvm.org/D21405