[PATCH] D21405: [PGO] IRPGO pre-cleanup pass changes

[Mehdi AMINI via llvm-commits]

mehdi_amini added a comment.

I really don't like the fact that the PGO pipeline will be different from the non-PGO pipeline (other than what is required for instrumentations). I wonder what other people will think of that.


================
Comment at: lib/Transforms/IPO/PassManagerBuilder.cpp:128
@@ -121,1 +127,3 @@
+                      cl::desc("Disable pre-instrumentation inliner"));
+
 PassManagerBuilder::PassManagerBuilder() {
----------------
Why two options?

================
Comment at: lib/Transforms/IPO/PassManagerBuilder.cpp:228
@@ +227,3 @@
+  return 75;
+}
+
----------------
These seem pretty arbitrary numbers?

================
Comment at: lib/Transforms/IPO/PassManagerBuilder.cpp:245
@@ -214,1 +244,3 @@
+    addExtensionsToPM(EP_Peephole, MPM);
+  }
   if (!PGOInstrGen.empty()) {
----------------
Where is this list coming from? How is it computed?


http://reviews.llvm.org/D21405