[PATCH] D21232: Add attribute noreturn to functions that throw

Sebastian Pop via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 15 11:36:29 PDT 2016


sebpop added a comment.

In http://reviews.llvm.org/D21232#458989, @mclow.lists wrote:

> I think a macro would be better here; something like `LIBCPP_NORETURN_IF_NO_EXCEPTIONS` rather than putting `__attribute__((__noreturn__))` everywhere.
>
> Besides, it makes it clear *why* these bits are being marked `noreturn`.
>
> What do you think?


Much nicer: thanks for the idea.
We will amend the patch and resubmit.


http://reviews.llvm.org/D21232





More information about the llvm-commits mailing list