[PATCH] D21149: [CodeView] Add support for emitting S_UDT for typedefs

[Reid Kleckner via llvm-commits]

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm


================
Comment at: lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:810
@@ +809,3 @@
+    LocalUDTs.emplace_back(std::move(FullyQualifiedName), UnderlyingTypeIndex);
+  }
+
----------------
Can you add a FIXME or TODO about how we would handle the 'else' case? We would have to perform all type translation before beginning emission of .debug$S, and then make LocalUDTs a member of FunctionInfo.

================
Comment at: test/DebugInfo/COFF/udts.ll:4
@@ +3,3 @@
+target triple = "i686-pc-windows-msvc18.0.0"
+
+; CHECK:      ProcStart {
----------------
Paste the C++ source and say something about how this is testing for local UDTs? I'm guessing it's:
  void f() {
    typedef int FOO;
    FOO f;
  }


http://reviews.llvm.org/D21149