[PATCH] D20842: [test-suite] Simplified test executable name generation.
Matthias Braun via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 14 16:19:52 PDT 2016
MatzeB accepted this revision.
MatzeB added a comment.
This revision is now accepted and ready to land.
LGTM, with one more comment below:
================
Comment at: cmake/modules/SingleMultiSource.cmake:202-204
@@ -181,1 +201,5 @@
+ set(executable ${PROG})
+ llvm_test_executable(${executable} ${sources})
+ target_include_directories(${executable} PUBLIC ${CMAKE_CURRENT_SOURCE_DIR})
+ target_include_directories(${executable} PUBLIC ${CMAKE_CURRENT_BINARY_DIR})
endif()
----------------
Shouldn't this be like:
```
llvm_test_executable(${executable} ${sources} TARGETS ${target})
target_include_directories(${target} ...)
```
http://reviews.llvm.org/D20842
More information about the llvm-commits
mailing list