[PATCH] D21194: Enable libFuzzer's afl_driver to append stderr to a file.

[Kostya Serebryany via llvm-commits]

kcc added a comment.

LGTM with nits. 
You don't have commit access, do you? 
Please ask Vitaly to land this for you


================
Comment at: lib/Fuzzer/afl/afl_driver.cpp:74
@@ +73,3 @@
+
+  assert(stderr_duplicate_stream &&
+         "Failed to duplicate stderr to AFL_DRIVER_STDERR_DUPLICATE_FILENAME");
----------------
assert is not good here as we may compile this w/o assertions. 
use
    if (!...stream) {
        fprintf(stderr,...);
        abort();
    }

================
Comment at: lib/Fuzzer/test/afl-driver.test:11
@@ +10,2 @@
+RUN: stat %t
+RUN: unset AFL_DRIVER_STDERR_DUPLICATE_FILENAME
----------------
no need for this


http://reviews.llvm.org/D21194