[PATCH] D12965: [InstCombine] shrink switch conditions better (PR24766)

[David Majnemer via llvm-commits]

majnemer added a comment.

In http://reviews.llvm.org/D12965#457687, @spatel wrote:

> In http://reviews.llvm.org/D12965#457658, @majnemer wrote:
>
> > Hmm.  My understanding was that InstCombine was not supposed to create IR with illegal types if it could help it.
>
>
> Do we state that anywhere? Should we make an exception for cases where we know that we have a fixup in a later pass (as we do for this in CGP)?
>
> I was proceeding based on Hal's earlier comment:
>  "We should shrink aggressively for our canonical form because smaller types convey the most information at the IR level."


https://github.com/llvm-mirror/llvm/blob/a2bdb6de81cd1de9daaeac9fa8bd24b6e0a48263/lib/Transforms/InstCombine/InstructionCombining.cpp#L91


http://reviews.llvm.org/D12965