[PATCH] D20310: Teach LLVM about Power 9 D-Form VSX Instructions

[Hal Finkel via llvm-commits]

hfinkel added inline comments.

================
Comment at: lib/Target/PowerPC/InstPrinter/PPCInstPrinter.cpp:451
@@ +450,3 @@
+    // (Please synchronize with PPCAsmPrinter::printOperand)
+    if ((MII.get(MI->getOpcode()).TSFlags & PPCII::UseVSXReg)) {
+      if (isVRRegister(Reg))
----------------
Can you please use something like this instead:

  MI->getDesc().OpInfo[MO's index].RegClass == PPC::VFRCRegClassID

and then get rid of the UseVSXReg flag?

================
Comment at: lib/Target/PowerPC/PPCMachineFunctionInfo.h:118
@@ +117,3 @@
+  /// slot can be spilled and reloaded by only one kind of register class.
+  std::map<int, const TargetRegisterClass *> StackSlotRC;
+
----------------
Use a DenseMap. You don't need to iterate over the ordering.


http://reviews.llvm.org/D20310