[PATCH] D21259: don't force SP-relative addressing for statepoints when the offset is not statically known

[David Majnemer via llvm-commits]

majnemer added inline comments.

================
Comment at: lib/CodeGen/PrologEpilogInserter.cpp:1101
@@ +1100,3 @@
+        auto SPOffset = TFI->getFrameIndexReferenceFromSP(Fn, MI->getOperand(i).getIndex(),
+                                                          Reg, false);
+        if (!SPOffset)
----------------
Please do something like `/*AllowSPAdjustment=*/false` so that readers can figure out what the bool parameter does.

================
Comment at: lib/CodeGen/PrologEpilogInserter.cpp:1105-1106
@@ -1100,1 +1104,4 @@
+                                                  Reg);
+        else
+          refOffset = *SPOffset;
 
----------------
I'd flip the sense of the comparison around.


http://reviews.llvm.org/D21259