[PATCH] D21254: [asan] Do not instrument pointers with address space attributes

[Kuba Brecka via llvm-commits]

kubabrecka added inline comments.

================
Comment at: test/Instrumentation/ThreadSanitizer/tsan_address_space_attr.ll:32
@@ +31,2 @@
+}
+; CHECK-NOT: addrspacecast
----------------
zaks.anna wrote:
> kubabrecka wrote:
> > kubabrecka wrote:
> > > Can we check for the presence of the instrumentation call instead?  The presence or non-presence of “addrspacecast” is a secondary thing.
> > (or CHECK-NOT for both if the previous code inserted an invalid addrspacecast)
> Can you clarify what you want to test for? 
> 
> Codegen crashes on the addrspacecast instruction. I can also test that the load is not instrumented with an additional check.
> 
> I can also test that the load is not instrumented with an additional check.

Yes please, that’s exactly what I meant.


http://reviews.llvm.org/D21254