[PATCH] D21288: [AArch64] Switch regression tests to test features not CPUs

silviu.baranga@arm.com via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 13 08:26:22 PDT 2016


sbaranga added a comment.

In http://reviews.llvm.org/D21288#456148, @rengolin wrote:

> Hi Silviu,
>
> I'm all for using target features, and that's a good way to make sure we test *all* CPUs, not just the one where the feature was introduced.
>
> Do we also need a small test to show that certain CPUs still have certain features? I'm not sure how to do that, though.
>
> cheers,
> --renato


Perhaps. That's something that we're already missing for most (all?) CPUs for these heuristics?
The best idea i can come up with is to make SubtargetEmitter.cpp generate some debug code that will print all features.

Cheers,
Silviu


http://reviews.llvm.org/D21288





More information about the llvm-commits mailing list