[PATCH] D19181: Map Attribute in the C API.

Amaury SECHET via llvm-commits llvm-commits at lists.llvm.org
Sat Jun 11 19:05:15 PDT 2016


deadalnix added inline comments.

================
Comment at: include/llvm-c/Core.h:536
@@ +535,3 @@
+ */
+LLVMBool LLVMIsEnumAttribute(LLVMAttributeRef A);
+LLVMBool LLVMIsIntAttribute(LLVMAttributeRef A);
----------------
whitequark wrote:
> `LLVMIsFlagAttribute`?
OK sooooooooo. As per the way things work, this will be true on all attribute that aren't flag but have the value 0 (this is how the code works under the hood).

Not sure what is the best path forward here, but Flag doesn't seems to be a good name.


http://reviews.llvm.org/D19181





More information about the llvm-commits mailing list