[PATCH] D21233: [CFLAA] Code cleanup: remove redundant node-to-value mapping and value-to-node mapping

Jia Chen via llvm-commits llvm-commits at lists.llvm.org
Sat Jun 11 12:14:19 PDT 2016


grievejia marked 2 inline comments as done.

================
Comment at: lib/Analysis/CFLAliasAnalysis.cpp:570
@@ +569,3 @@
+    auto &FromEdges = getOrCreateNode(From);
+    auto &ToEdges = getOrCreateNode(To);
+    FromEdges.push_back(Edge{Attr, Type, To});
----------------
george.burgess.iv wrote:
> This looks like it can make `FromEdges` a dangling reference if we resize the map while adding `To` :)
This is subtle! Thanks for catching it. 


http://reviews.llvm.org/D21233





More information about the llvm-commits mailing list