[PATCH] D21018: [ELF] - Basic versioned symbols support implemented.
George Rimar via llvm-commits
llvm-commits at lists.llvm.org
Sat Jun 11 08:50:34 PDT 2016
grimar added inline comments.
================
Comment at: ELF/SymbolListFile.cpp:106-108
@@ +105,5 @@
+ while (!atEOF() && !Error) {
+ Config->SymbolVersions.push_back({next(), {}});
+ Version &V = Config->SymbolVersions.back();
+
+ expect("{");
----------------
ruiu wrote:
> Then how about defining a constructor that takes a StringRef?
Done. That is not very consistent with other lld code, but solves the problem.
(actually I just do not understand why it can not be solved(fixed) in clang, as this feature of c++ language looks
pretty cool for me).
http://reviews.llvm.org/D21018
More information about the llvm-commits
mailing list