[PATCH] D21215: [docs] Update AMDGPU relocation information

Tye, Tony via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 10 22:42:06 PDT 2016


The old R_AMDGPU_ABS32_LO and the new R_AMDGPU_ABS32 are in fact the same thing. The & 0xffffffff is implicitly done because the result of the R_AMDGPU_ABS32 is a word32 not a word64. So putting in the & 0xffffffff is redundant. The other ABI documents (such as for the x86) do not put in the & 0xffffffff so it seemed best to follow their conventions. R_AMDGPU_ABS32_HI and R_AMDGPU_ABS32 both return 32 bits as they are both defined as word32. They differ in that R_AMDGPU_ABS32_HI takes the address and shifts it right by 32 bits which effectively means that the top 32 bits of the 64 bit address are returned, not the bottom 32 bits.

> On Jun 10, 2016, at 9:15 PM, Tom Stellard <thomas.stellard at amd.com> wrote:
> 
> tstellarAMD added a comment.
> 
> I agree with Rafael here, can we keep R_AMDGPU_ABS32_LO and then just add R_AMDGPU_ABS32 as a separate relocation?
> 
> 
> http://reviews.llvm.org/D21215
> 
> 
> 



More information about the llvm-commits mailing list