[polly] r271512 - [FIX] Ensure wrapping checks for unary expressions

Tobias Grosser via llvm-commits llvm-commits at lists.llvm.org
Sat Jun 11 02:42:44 PDT 2016


On Wed, Jun 8, 2016, at 10:58 AM, Johannes Doerfert via llvm-commits
wrote:
> On 06/07, Tobias Grosser wrote:
> > On 06/02/2016 01:08 PM, Johannes Doerfert via llvm-commits wrote:
> > > Author: jdoerfert
> > > Date: Thu Jun  2 06:08:43 2016
> > > New Revision: 271512
> > > 
> > > URL: http://llvm.org/viewvc/llvm-project?rev=271512&view=rev
> > > Log:
> > > [FIX] Ensure wrapping checks for unary expressions
> > 
> > Hi Johannes,
> > 
> > any reason you could not add a test case here?
> No not particularly. I guess one has to use the json import to ensure
> an unary minus in front of a value that did not have one before.

Great. Could you please then please add such test case?

As you surely  know LLVM has an explicit policy of adding test cases
[1]. Obviously, in case adding a test case is very hard to extract  or
likely to not be useful this policy can not be followed. However, as it
seems easy in this case I would like have us set a good example - also
for our GSoC students to follow.

Best,
Tobias

[1] http://llvm.org/docs/DeveloperPolicy.html#test-cases 


More information about the llvm-commits mailing list