[PATCH] D20993: Add support for collating profiles for use with code coverage

Vedant Kumar via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 10 16:35:58 PDT 2016


vsk added a comment.

In http://reviews.llvm.org/D20993#454452, @davidxl wrote:

> Why choosing default size of 9? Do you have build time comparison numbers i.e., pool size from 1 to 9?


I chose 9 because it's the highest option: a larger pool of raw profiles should theoretically lead to less lock contention. Ideally this would be some factor of the number of threads on the system. However, I don't think it's worth optimizing this default.

> Also, writing it in Python makes it pretty portable for free and is generally more readable.


Sure, I'll upload a new diff with this change.


http://reviews.llvm.org/D20993





More information about the llvm-commits mailing list