[llvm] r272420 - Move isGuaranteedToExecute out of LICM.

Evgenii Stepanov via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 10 15:03:53 PDT 2016


Thanks for bringing this up!
I'm using this in r272421 and don't plan to use it anywhere else.

r272421 fixes an immediate and incredibly rare problem with MSan that
is currently breaking one of the bots, it's good enough for now, and
it looks like D21167 will benefit both that and the original LICM
problem (once you rebase it of course, sorry about the churn).

On Fri, Jun 10, 2016 at 2:17 PM, Eli Friedman <eli.friedman at gmail.com> wrote:
> On Fri, Jun 10, 2016 at 1:03 PM, Evgeniy Stepanov via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
>>
>> Author: eugenis
>> Date: Fri Jun 10 15:03:17 2016
>> New Revision: 272420
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=272420&view=rev
>> Log:
>> Move isGuaranteedToExecute out of LICM.
>>
>> Also rename LICMSafetyInfo to LoopSafetyInfo.
>> Both will be used in LoopUnswitch in a separate change.
>
>
> isGuaranteedToExecute has known issues.  See http://reviews.llvm.org/D21167
> .  See https://llvm.org/bugs/show_bug.cgi?id=24078 .  You're probably
> introducing bugs if you intend to add more uses.
>
> -Eli


More information about the llvm-commits mailing list