[PATCH] D19373: Remangle intrinsics names when types are renamed

[Mehdi AMINI via llvm-commits]

mehdi_amini added a comment.

Tests for all theses cases?


================
Comment at: lib/AsmParser/LLParser.cpp:224
@@ +223,3 @@
+        if (CallSite CS = CallSite(U))
+          CS.setCalledFunction(Remangled.getValue());
+      F->eraseFromParent();
----------------
RAUW?

================
Comment at: lib/Bitcode/Reader/BitcodeReader.cpp:5587
@@ +5586,3 @@
+        if (CallInst *CI = dyn_cast<CallInst>(U))
+          Do(CI, I.second);
+      }
----------------
Why do we update only calls and not all uses? 
If we don't expect any other use of an intrinsic than calls, then we should just cast.

================
Comment at: lib/IR/Function.cpp:1050
@@ +1049,3 @@
+Optional<Function*> Intrinsic::remangleIntrinsicFunction(Function *F) {
+  Intrinsic::ID id = F->getIntrinsicID();
+  if (!id)
----------------
ping (upper case for variable)


http://reviews.llvm.org/D19373